Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | config: use semicolon to comment out descriptions in config files | Koichiro IWAO | 2016-11-16 | 1 | -31/+31 |
| | | | | | | | | and use number sign to comment out actual configurations. For example: ; if set to true, enables foobar #foobar=true | ||||
* | config: unify all boolean values in config to true/false | Koichiro IWAO | 2016-11-16 | 1 | -7/+6 |
| | |||||
* | Omit numbers from the "param" keys, they are not needed | Pavel Roskin | 2016-11-15 | 1 | -23/+23 |
| | | | | | Users assume that they need to renumber the parameters. That makes parameter editing more involved than it needs to be. | ||||
* | Merge pull request #454 from metalefty/change-chansrv-log-path | metalefty | 2016-11-07 | 1 | -0/+40 |
|\ | | | | | chansrv: change chansrv log path to ${XDG_DATA_HOME}/xrdp | ||||
| * | chansrv: change chansrv log path to ${XDG_DATA_HOME}/xrdp | Koichiro IWAO | 2016-10-25 | 1 | -0/+40 |
| | | | | | | | | | | | | | | like Xorg's logfile is written to ${XDG_DATA_HOME}/xorg/Xorg.n.log. If XDG_DATA_HOME is not defined, the log path will be ${HOME}/.local/share/xrdp. | ||||
* | | Move -logfile /dev/null option for easier commenting in debug scenarios. | Dominik George | 2016-10-28 | 1 | -6/+6 |
|/ | |||||
* | Fix memory leak in xrdp-sesman on config reload | Pavel Roskin | 2016-10-21 | 3 | -0/+22 |
| | |||||
* | Memory leak fix: keep X server path in the parameter list | Pavel Roskin | 2016-10-21 | 1 | -6/+3 |
| | | | | | | | | | | | g_cfg->xorg_params, g_cfg->vnc_params and g_cfg->rdp_params don't have auto_free enabled, so removing an item from one of those lists won't free its contents. It's better not to change those lists, as they represent the actual config file and could be reused. Instead, omit the 0th parameter (the executable path) from copying to xserver_params. Found by Valgrind. | ||||
* | Call auth_end() exactly once in scp_v0_process() | Pavel Roskin | 2016-10-21 | 1 | -5/+1 |
| | | | | As discovered by Valgrind, it wasn't called at all in case of a successful session creation, which leaked memory. | ||||
* | Fix memory leak: free session data | Pavel Roskin | 2016-10-21 | 4 | -10/+8 |
| | | | | | | | Call scp_session_destroy() in the functions that call scp_session_create() and nowhere else. As found by Valgrind, the session data is not freed if the session is created successfully. | ||||
* | Get rid of EXTRA_LIBS, use variables with more specific names | Pavel Roskin | 2016-10-20 | 1 | -6/+6 |
| | |||||
* | Eliminate EXTRA_FLAGS, it's a poor name, use AM_LDFLAGS | Pavel Roskin | 2016-10-20 | 1 | -3/+1 |
| | |||||
* | Merge EXTRA_DEFINES and EXTRA_INCLUDES into AM_CPPFLAGS | Pavel Roskin | 2016-10-20 | 1 | -14/+10 |
| | | | | | | | | | | AM_CPPFLAGS is a documented Automake variable for C preprocessor flags that should not be overridden when compiling the package. There is no need to have two additional variables that are ultimately merged into AM_CPPFLAGS. Their names are also confusing. EXTDA_DIST is a documented Automake variable. Everything else that starts with "EXTRA" is not. | ||||
* | Use const pointers in function arguments when possible | Pavel Roskin | 2016-10-17 | 12 | -26/+28 |
| | |||||
* | Fix wrong comments in sesman config printing code | Pavel Roskin | 2016-10-17 | 1 | -4/+4 |
| | |||||
* | Fix incorrect description of auth_userpass() return value | Pavel Roskin | 2016-10-17 | 1 | -1/+1 |
| | |||||
* | Don't use final newline in log calls, it's already appended | Pavel Roskin | 2016-10-17 | 4 | -11/+11 |
| | |||||
* | Log malloc errors with LOG_LEVEL_ERROR | Pavel Roskin | 2016-10-17 | 2 | -2/+2 |
| | |||||
* | Don't close socket in scp_process_start(), the caller closes it | Pavel Roskin | 2016-09-08 | 1 | -1/+0 |
| | |||||
* | g_term_event is a wait object, not TCP socket, delete it correctly | Pavel Roskin | 2016-09-08 | 1 | -1/+1 |
| | |||||
* | sesrun: remove unused g_sck and write-only g_pid | Pavel Roskin | 2016-09-08 | 1 | -4/+0 |
| | |||||
* | sesman: don't close listening socket in signal handler | Pavel Roskin | 2016-09-08 | 1 | -2/+0 |
| | | | | It is closed when the main loop terminates. | ||||
* | chansrv: pathname also should be URL decoded | Koichiro IWAO | 2016-08-30 | 1 | -0/+1 |
| | | | | | | | | because 1st argument to clipboard_get_file() is given as URL encoded. Decoding only filename is incomplete. Without this fix, clipboard file doesn't work in case pathname contains non-ASCII characters or non-alphanumeric ASCII characters. | ||||
* | Merge pull request #390 from proski/june21 | jsorg71 | 2016-08-05 | 33 | -197/+114 |
|\ | | | | | Cleanups and C++ compatibility | ||||
| * | Use enum logLevels consistently for log levels | Pavel Roskin | 2016-07-08 | 2 | -6/+6 |
| | | |||||
| * | Fix return type of devredir_fuse_data_peek and devredir_fuse_data_dequeue | Pavel Roskin | 2016-07-08 | 2 | -4/+4 |
| | | |||||
| * | Use cast when applying boolean OR to enum | Pavel Roskin | 2016-07-08 | 1 | -1/+3 |
| | | |||||
| * | Fix signed to unsigned comparisons reported by g++ 6.1.0 | Pavel Roskin | 2016-07-08 | 6 | -11/+13 |
| | | |||||
| * | Use g_new or g_new0 when C++ compiler would complain about implicit cast | Pavel Roskin | 2016-07-08 | 13 | -21/+25 |
| | | |||||
| * | Cast appdata_ptr explicitly, needed for C++ compatibility | Pavel Roskin | 2016-07-08 | 1 | -2/+2 |
| | | |||||
| * | Mark g_drdynvc_chan_id as extern in g_drdynvc_chan_id, it's in chansrv.c | Pavel Roskin | 2016-07-08 | 1 | -1/+1 |
| | | |||||
| * | Use const unsigned for hex arrays | Pavel Roskin | 2016-07-08 | 2 | -3/+3 |
| | | | | | | Some constants are too big for the signed type. | ||||
| * | Fix warnings detected by -Wwrite-strings | Pavel Roskin | 2016-07-08 | 10 | -32/+35 |
| | | |||||
| * | Make program_name constant, don't duplicate or free it | Pavel Roskin | 2016-07-08 | 2 | -2/+2 |
| | | |||||
| * | Remove commented out config_read_logging(), the code is long dead | Pavel Roskin | 2016-07-08 | 1 | -55/+0 |
| | | |||||
| * | Remove unused string support in scp_session_set_addr() | Pavel Roskin | 2016-07-08 | 5 | -44/+6 |
| | | | | | | | | | | | | | | | | Using the same argument for binary and text data is not a good idea. If string support is ever needed, it should be a separate function. Remove SCP_ADDRESS_TYPE_IPV4_BIN and SCP_ADDRESS_TYPE_IPV6_BIN, use SCP_ADDRESS_TYPE_IPV4 and SCP_ADDRESS_TYPE_IPV6, which simplifies the code. | ||||
| * | Downgrade "libscp initialized" to LOG_LEVEL_DEBUG, remove line number | Pavel Roskin | 2016-07-08 | 1 | -1/+1 |
| | | | | | | | | It's a bad style to start the log with a cryptic warning. | ||||
| * | Fix scp_init() invocation, it takes no arguments | Pavel Roskin | 2016-07-08 | 2 | -2/+2 |
| | | |||||
| * | Fix format warnings in log_message() calls | Pavel Roskin | 2016-06-21 | 3 | -4/+4 |
| | | |||||
| * | Report pid and listening address/port for xrdp and xrdp-sesman | Pavel Roskin | 2016-06-21 | 1 | -5/+4 |
| | | | | | | | | | | | | For xrdp-sesman, don't report that the daemon is listening to a port if it fails to attach to that port. Don't use LOG_LEVEL_ALWAYS for startup message, it's not a critical error. | ||||
| * | Rename SESMAN_CFG_X11DISPLAYOFFSET to SESMAN_CFG_SESS_X11DISPLAYOFFSET | Pavel Roskin | 2016-06-21 | 2 | -2/+2 |
| | | | | | | | | | | Move it to other session options in config.h. X11DisplayOffset is part of the [Sessions] section. | ||||
| * | Fix incorrect use of "it's" and "its", adjust wording | Pavel Roskin | 2016-06-21 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #388 from metalefty/freebsd/fuse | jsorg71 | 2016-08-05 | 1 | -1/+1 |
|\ \ | | | | | | | sesman: Add /sbin to PATH for FreeBSD | ||||
| * | | sesman: Add /sbin to PATH for FreeBSD | Koichiro IWAO | 2016-06-20 | 1 | -1/+1 |
| |/ | | | | | | | | | | | | | | | | | | | | | to enable to execute FUSE mount program. The place of FUSE mount programs are: FreeBSD : /sbin/mount_fusefs GNU/Linux : /bin/fusermount See also #387. | ||||
* | | Merge branch 'devel' of https://github.com/neutrinolabs/xrdp into devel | speidy | 2016-07-26 | 5 | -35/+667 |
|\ \ | |||||
| * | | chansrv: avoid chansrv SEGV when xinode is NULL | Kentaro Hayashi | 2016-07-21 | 2 | -1/+10 |
| | | | | | | | | | | | | | | | | | | | | | When xfuse_create_file_in_xrdp_fs is failed, it returns NULL. Without this fix, xinode->size causes SEGV, so implementation is changed to return -1 and check the return value in caller. | ||||
| * | | chansrv: added mp3 compression from Speidy | Jay Sorg | 2016-07-13 | 3 | -34/+657 |
| |/ | |||||
* | | sesman: env_set_user, fix potential bof issues | speidy | 2016-07-22 | 3 | -29/+71 |
|/ | |||||
* | Remove unused variable in devredir_cvt_from_unicode_len() | Pavel Roskin | 2016-05-06 | 1 | -2/+1 |
| | |||||
* | Remove unused variables from dev_redir_proc_query_dir_response() | Pavel Roskin | 2016-05-06 | 1 | -15/+5 |
| |